Skip to content

fix: base_extent calculation in bits_locator_t::template extent_in() #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: base_extent calculation in bits_locator_t::template extent_in() #641

wants to merge 1 commit into from

Conversation

samvangysegem
Copy link

The base_extent variable in the extent_in() method of the bits_locator_t struct now uses the size of its template parameter T instead of std::uint32_t for calculating the base extent .

@elbeno
Copy link
Contributor

elbeno commented Oct 30, 2024

I don't think this is right - the Index is always in dwords, hence computing the extent in bytes uses sizeof(std::uint32_t).

@samvangysegem
Copy link
Author

You're right... I wrongly assumed the Index of the field_locator_t would correspond to the size of the type being held in the underlying storage of the message. Thanks for clarifying! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samvangysegem @elbeno